Skip to content

stream: error Duplex write/read if not writable/readable #34385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 11 commits into from
Closed

stream: error Duplex write/read if not writable/readable #34385

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
157b6fe
stream: error Duplex write/read if not writable/readable
ronag Jul 15, 2020
35c7e5e
fixup
ronag Jan 5, 2021
43e1037
fixup
ronag Jan 5, 2021
9e4fbbb
fixup
ronag Jan 6, 2021
e68fcc8
fixup
ronag Jan 6, 2021
5468625
fixup
ronag Jan 6, 2021
5e9a6f4
fixup
ronag Jul 1, 2021
6fe226b
fixup
ronag Jul 1, 2021
45108ac
fixup
ronag Jul 2, 2021
8259042
fixup: re-enable dumb tty
ronag Jul 2, 2021
71a9b6e
fixup
ronag Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: re-enable dumb tty
  • Loading branch information
@ronag
ronag committed Jul 2, 2021
commit 8259042341e93a3bb3f751c13b71269c0c27481d
62 changes: 29 additions & 33 deletions test/pseudo-tty/repl-dumb-tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,37 @@
const common = require('../common');
const process = require('process');

// TODO (fix): So this work on darwin/linux?
if (process.env === 'windows') {
process.env.TERM = 'dumb';
process.env.TERM = 'dumb';

const repl = require('repl');
const ArrayStream = require('../common/arraystream');
const repl = require('repl');
const ArrayStream = require('../common/arraystream');

repl.start('> ');
repl.start('> ');

// Verify <ctrl> + D support.
{
const stream = new ArrayStream();
const replServer = new repl.REPLServer({
prompt: '> ',
terminal: true,
input: stream,
output: process.stdout,
useColors: false
});

replServer.on('close', common.mustCall());
// Verify that <ctrl> + R or <ctrl> + C does not trigger the reverse search.
replServer.write(null, { ctrl: true, name: 'r' });
replServer.write(null, { ctrl: true, name: 's' });
replServer.write(null, { ctrl: true, name: 'd' });
}

process.stdin.push('conso'); // No completion preview.
process.stdin.push('le.log("foo")\n');
process.stdin.push('1 + 2'); // No input preview.
process.stdin.push('\n');
process.stdin.push('"str"\n');
process.stdin.push('console.dir({ a: 1 })\n');
process.stdin.push('{ a: 1 }\n');
process.stdin.push('\n');
process.stdin.push('.exit\n');
// Verify <ctrl> + D support.
{
const stream = new ArrayStream();
const replServer = new repl.REPLServer({
prompt: '> ',
terminal: true,
input: stream,
output: process.stdout,
useColors: false
});

replServer.on('close', common.mustCall());
// Verify that <ctrl> + R or <ctrl> + C does not trigger the reverse search.
replServer.write(null, { ctrl: true, name: 'r' });
replServer.write(null, { ctrl: true, name: 's' });
replServer.write(null, { ctrl: true, name: 'd' });
}

process.stdin.push('conso'); // No completion preview.
process.stdin.push('le.log("foo")\n');
process.stdin.push('1 + 2'); // No input preview.
process.stdin.push('\n');
process.stdin.push('"str"\n');
process.stdin.push('console.dir({ a: 1 })\n');
process.stdin.push('{ a: 1 }\n');
process.stdin.push('\n');
process.stdin.push('.exit\n');