Skip to content

src: add callback scope for native immediates #34366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: add callback scope for native immediates #34366

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6410b65
src: add callback scope for native immediates
addaleax Jul 14, 2020
1309b61
fixup! src: add callback scope for native immediates
addaleax Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: add callback scope for native immediates
  • Loading branch information
@addaleax
addaleax committed Jul 14, 2020
commit 1309b616d73842a162ebbed1fbe43388a966efa0
16 changes: 9 additions & 7 deletions test/async-hooks/test-late-hook-enable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@ const fnsToTest = [setTimeout, (cb) => {
});
});
}, (cb) => {
process.nextTick(() => {
cb();
setImmediate(() => {
process.nextTick(() => {
cb();

// We need to keep the event loop open for this to actually work
// since destroy hooks are triggered in unrefed Immediates
setImmediate(() => {
hook.disable();
assert.strictEqual(fnsToTest.length, 0);
// We need to keep the event loop open for this to actually work
// since destroy hooks are triggered in unrefed Immediates
setImmediate(() => {
hook.disable();
assert.strictEqual(fnsToTest.length, 0);
});
});
});
}];
Expand Down