Skip to content

[v14.x] deps: update V8 to 8.4 #34356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 21 commits into from
Closed

[v14.x] deps: update V8 to 8.4 #34356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
101a4e5
deps: update V8 to 8.4.371.19
targos Jul 14, 2020
d0a3a41
build: reset embedder string to "-node.0"
targos Jul 14, 2020
8be298d
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
332374e
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
dc9a411
deps: V8: patch register-arm64.h
refack May 22, 2019
b27fe7e
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
f997e43
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
183e0ae
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
722f765
deps: patch V8 to run on Xcode 8
mmarchini Mar 10, 2020
65af1a7
deps: V8: cherry-pick 9868b2aefa1a
targos Jun 2, 2020
43c1e9f
deps: V8: fix compilation on VS2017
gengjiawen Jun 2, 2020
b949068
deps: V8: backport 22014de00115
joyeecheung May 29, 2020
4ab20df
deps: V8: cherry-pick eec10a2fd8fa
Qard Jun 6, 2020
64dcfc7
deps: update V8 postmortem metadata script
cjihrig Jul 4, 2020
da92783
tools: update V8 gypfiles for 8.4
ryzokuken Apr 17, 2020
6dec877
deps: bump minimum icu version to 67
targos May 9, 2020
dd1f4e7
test: remove test/v8-updates/test-postmortem-metadata.js
cjihrig Jun 29, 2020
2362639
deps: V8: undo header change of 9dbab9bbdb979
addaleax Jul 14, 2020
c940cb7
deps: V8: re-add dummy Isolate::CheckMemoryPressure
addaleax Jul 14, 2020
4fcd9c2
deps: V8: revert de4c0042cbe6 from upstream V8
addaleax Jul 14, 2020
9ff6a3b
deps: V8: update headers for ABI compatibility
addaleax Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: make v8.h compatible with VS2015 
There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.

Refs: https://stackoverflow.com/q/38378693

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@joaocgreis @targos
joaocgreis authored and targos committed Jul 16, 2020
commit f997e43a415c3110c0f722a5f9e718a86aa8cd08
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.4',
'v8_embedder_string': '-node.5',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/include/v8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,9 +1756,11 @@ class V8_EXPORT ScriptCompiler {
public:
enum Encoding { ONE_BYTE, TWO_BYTE, UTF8 };

#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
V8_DEPRECATE_SOON(
"This class takes ownership of source_stream, so use the constructor "
"taking a unique_ptr to make these semantics clearer")
#endif
StreamedSource(ExternalSourceStream* source_stream, Encoding encoding);
StreamedSource(std::unique_ptr<ExternalSourceStream> source_stream,
Encoding encoding);
Expand Down