Skip to content

src: avoid strcmp in SecureContext::Init #34329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 3 commits into from
Closed

src: avoid strcmp in SecureContext::Init #34329

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c5d55f
src: avoid strcmp in SecureContext::Init
tniessen Jul 12, 2020
24487c9
fixup! src: avoid strcmp in SecureContext::Init
tniessen Jul 13, 2020
c6cf437
fixup! src: avoid strcmp in SecureContext::Init
tniessen Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: avoid strcmp in SecureContext::Init
  • Loading branch information
@tniessen
tniessen committed Jul 17, 2020
commit c6cf437d03dd7d6a2c1a05cc3a6b6d9d0ba4c464
2 changes: 1 addition & 1 deletion src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args) {
method = TLS_client_method();
} else {
const std::string msg("Unknown method: ");
THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, (msg + *sslmethod).c_str());
THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, (msg + * sslmethod).c_str());
return;
}
}
Expand Down