Skip to content

quic: more quic refactorings and cleanups #34283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 18 commits into from
Closed

quic: more quic refactorings and cleanups #34283

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b17ab97
quic: replace ipv6Only option with `'udp6-only'` type
jasnell Jul 9, 2020
63b79fd
quic: minor reduction in code duplication
jasnell Jul 9, 2020
cc4674d
quic: clarifying code comments
jasnell Jul 9, 2020
99b37e0
quic: use a getter for stream options
jasnell Jul 9, 2020
7297f70
quic: restrict addEndpoint to before QuicSocket bind
jasnell Jul 9, 2020
8ffa9e8
quic: fix endpointClose error handling, document
jasnell Jul 9, 2020
b3a51d4
quic: fixup kEndpointClose
jasnell Jul 9, 2020
fcfa129
quic: handle unhandled rejections on QuicSession
jasnell Jul 9, 2020
5fde41c
quic: implement QuicEndpoint Promise API
jasnell Jul 9, 2020
d9f529a
quic: implement QuicSocket Promise API, part 1
jasnell Jul 10, 2020
9e67b30
quic: implement QuicSocket Promise API, part 2
jasnell Jul 10, 2020
cec7b11
quic: eliminate "ready"/"not ready" states for QuicSession
jasnell Jul 10, 2020
2acd3dd
quic: use promisified dns lookup
jasnell Jul 10, 2020
2ac3158
quic: cleanup QuicClientSession constructor
jasnell Jul 10, 2020
0427d0d
quic: implement QuicSession close as promise
jasnell Jul 10, 2020
9e9d294
quic: properly pass readable/writable constructor options
jasnell Jul 11, 2020
2717356
quic: fixup closing/draining period timing
jasnell Jul 13, 2020
dd5109a
quic: fixup quic.md
jasnell Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: clarifying code comments
  • Loading branch information
@jasnell
jasnell committed Jul 16, 2020
commit cc4674d34100efd9c90d1a2f29f8afc9f6a34f5c
8 changes: 8 additions & 0 deletions lib/internal/quic/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,13 @@ class QuicEndpoint {

this[kHandle] = undefined;
handle[owner_symbol] = undefined;
// Calling waitForPendingCallbacks starts the process of
// closing down the QuicEndpoint. Once all pending writes
// to the underlying libuv udp handle have completed, the
// ondone callback will be invoked, triggering the UDP
// socket to be closed. Once it is closed, we notify
// the QuicSocket that this QuicEndpoint has been closed,
// allowing it to be freed.
handle.ondone = () => {
state.udpSocket.close((err) => {
if (err) error = err;
Expand Down Expand Up @@ -747,6 +754,7 @@ class QuicEndpoint {
return {};
}

// On Windows, this always returns undefined.
get fd() {
return this[kInternalState].fd >= 0 ?
this[kInternalState].fd : undefined;
Expand Down