Skip to content

domain: fix unintentional deprecation warning #34245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

domain: fix unintentional deprecation warning #34245

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e53bd
domain: fix unintentional deprecation warning
addaleax Jul 7, 2020
0d44c74
fixup! domain: fix unintentional deprecation warning
addaleax Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! domain: fix unintentional deprecation warning
  • Loading branch information
@addaleax
addaleax committed Jul 7, 2020
commit 0d44c74362c83d445459f60f8662326ffba3614a
4 changes: 2 additions & 2 deletions lib/internal/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function useDomainTrampoline(fn) {
}

function callbackTrampoline(asyncId, cb, ...args) {
if (asyncId && hasHooks(kBefore))
if (asyncId !== 0 && hasHooks(kBefore))
emitBeforeNative(asyncId);

let result;
Expand All @@ -123,7 +123,7 @@ function callbackTrampoline(asyncId, cb, ...args) {
result = ReflectApply(cb, this, args);
}

if (asyncId && hasHooks(kAfter))
if (asyncId !== 0 && hasHooks(kAfter))
emitAfterNative(asyncId);

return result;
Expand Down