Skip to content

repl: fix verb conjugation in deprecation message #34198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

repl: fix verb conjugation in deprecation message #34198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
repl: fix verb conjugation in deprecation message
  • Loading branch information
@Trott
Trott committed Jul 4, 2020
commit 6fe8ffbbd871db34190ea42e617d522ce6f22f86
8 changes: 4 additions & 4 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,13 @@ function REPLServer(prompt,
ObjectDefineProperty(this, 'inputStream', {
get: pendingDeprecation ?
deprecate(() => this.input,
'repl.inputStream and repl.outputStream is deprecated. ' +
'repl.inputStream and repl.outputStream are deprecated. ' +
'Use repl.input and repl.output instead',
'DEP0141') :
() => this.input,
set: pendingDeprecation ?
deprecate((val) => this.input = val,
'repl.inputStream and repl.outputStream is deprecated. ' +
'repl.inputStream and repl.outputStream are deprecated. ' +
'Use repl.input and repl.output instead',
'DEP0141') :
(val) => this.input = val,
Expand All @@ -241,13 +241,13 @@ function REPLServer(prompt,
ObjectDefineProperty(this, 'outputStream', {
get: pendingDeprecation ?
deprecate(() => this.output,
'repl.inputStream and repl.outputStream is deprecated. ' +
'repl.inputStream and repl.outputStream are deprecated. ' +
'Use repl.input and repl.output instead',
'DEP0141') :
() => this.output,
set: pendingDeprecation ?
deprecate((val) => this.output = val,
'repl.inputStream and repl.outputStream is deprecated. ' +
'repl.inputStream and repl.outputStream are deprecated. ' +
'Use repl.input and repl.output instead',
'DEP0141') :
(val) => this.output = val,
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-repl-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ common.expectWarning({
DeprecationWarning: {
DEP0142:
'repl._builtinLibs is deprecated. Check module.builtinModules instead',
DEP0141: 'repl.inputStream and repl.outputStream is deprecated. ' +
DEP0141: 'repl.inputStream and repl.outputStream are deprecated. ' +
'Use repl.input and repl.output instead',
}
});
Expand Down