Skip to content

v10.22.0 proposal #34170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BethGriggs merged 22 commits into from
Jul 21, 2020
Merged

v10.22.0 proposal #34170

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
24b927a
build: allow clang 10+ in configure.py
krytarowski Sep 13, 2019
145dcc2
build: move doc versions JSON file out of out/doc
richardlau Apr 8, 2020
5436569
test: flaky test-stdout-close-catch on freebsd
sam-github Apr 14, 2020
9915774
build: log detected compilers in --verbose mode
richardlau Apr 8, 2020
89a306b
deps: fix V8 compiler error with clang++-11
sam-github Apr 27, 2020
3acc89f
deps: V8: backport cd21f71f9cb5
targos Jun 13, 2020
aaf2f82
inspector: more conservative minimum stack size
bnoordhuis May 24, 2019
ef9413b
deps: upgrade openssl sources to 1.1.1f
hassaanp Mar 31, 2020
94702c1
deps: upgrade openssl sources to 1.1.1g
hassaanp Apr 21, 2020
745b329
deps: update archs files for OpenSSL-1.1.1g
hassaanp Apr 21, 2020
74b00cc
tls: allow empty subject even with altNames defined
jasonmacgowan Sep 17, 2018
193d1d0
doc: document fs.watchFile() bigint option
cjihrig Mar 6, 2020
3dbd8cd
Revert "test: mark empty udp tests flaky on OS X"
lpinca Mar 25, 2020
961598b
n-api: add `napi_detach_arraybuffer`
legendecas Apr 25, 2020
b744ffd
n-api: implement napi_is_detached_arraybuffer
lundibundi Nov 23, 2019
5dab101
doc,n-api: mark napi_detach_arraybuffer as experimental
legendecas Nov 28, 2019
069b6e1
http: disable headersTimeout check when set to zero
ShogunPanda Apr 29, 2020
84fca3c
deps: upgrade npm to 6.14.5
ruyadorno May 4, 2020
97b5952
deps: upgrade npm to 6.14.6
claudiahdz Jul 7, 2020
7a109fe
test: remove timers-blocking-callback
Fishrock123 Apr 15, 2020
00f04e3
doc: fix quotes in tls.md
sparsh-99 May 29, 2020
c5215d0
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
richardlau Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
inspector: more conservative minimum stack size 
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
which is the musl architecture with the biggest MINSIGSTKSZ so let's
use that as a lower bound and let's quadruple it just in case.

Backport-PR-URL: #33720
PR-URL: #27855
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@bnoordhuis @richardlau
bnoordhuis authored and richardlau committed Jul 1, 2020
commit aaf2f827c6f1be1bdb73d1a6293d6b8f45fce4bf
19 changes: 13 additions & 6 deletions src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#include "libplatform/libplatform.h"

#include <algorithm>
#include <string.h>
#include <sstream>
#include <unordered_map>
Expand Down Expand Up @@ -101,12 +102,18 @@ static int StartDebugSignalHandler() {
CHECK_EQ(0, uv_sem_init(&start_io_thread_semaphore, 0));
pthread_attr_t attr;
CHECK_EQ(0, pthread_attr_init(&attr));
// Don't shrink the thread's stack on FreeBSD. Said platform decided to
// follow the pthreads specification to the letter rather than in spirit:
// https://lists.freebsd.org/pipermail/freebsd-current/2014-March/048885.html
#ifndef __FreeBSD__
CHECK_EQ(0, pthread_attr_setstacksize(&attr, PTHREAD_STACK_MIN));
#endif // __FreeBSD__
#if defined(PTHREAD_STACK_MIN) && !defined(__FreeBSD__)
// PTHREAD_STACK_MIN is 2 KB with musl libc, which is too small to safely
// receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64, which
// is the musl architecture with the biggest MINSIGSTKSZ so let's use that
// as a lower bound and let's quadruple it just in case. The goal is to avoid
// creating a big 2 or 4 MB address space gap (problematic on 32 bits
// because of fragmentation), not squeeze out every last byte.
// Omitted on FreeBSD because it doesn't seem to like small stacks.
const size_t stack_size = std::max(static_cast<size_t>(4 * 8192),
static_cast<size_t>(PTHREAD_STACK_MIN));
CHECK_EQ(0, pthread_attr_setstacksize(&attr, stack_size));
#endif // defined(PTHREAD_STACK_MIN) && !defined(__FreeBSD__)
CHECK_EQ(0, pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED));
sigset_t sigmask;
// Mask all signals.
Expand Down