Skip to content

test: add regression test for C++-created Buffer transfer #34140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

test: add regression test for C++-created Buffer transfer #34140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: add regression test for C++-created Buffer transfer 
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: #34126
  • Loading branch information
@addaleax
addaleax committed Jun 30, 2020
commit 0239467106b877189ee5512822ad708067fa51fe
30 changes: 30 additions & 0 deletions test/parallel/test-worker-crypto-sign-transfer-result.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const { Worker } = require('worker_threads');
const fixturesPath = require.resolve('../common/fixtures');

// Test that transferring the result of e.g. crypto.sign() from Worker to parent
// thread does not crash

const w = new Worker(`
const { parentPort } = require('worker_threads');
const crypto = require('crypto');
const assert = require('assert');
const fixtures = require(${JSON.stringify(fixturesPath)});

const keyPem = fixtures.readKey('rsa_private.pem');

const buf = crypto.sign('sha256', Buffer.from('hello'), keyPem);
assert.notStrictEqual(buf.byteLength, 0);
parentPort.postMessage(buf, [buf.buffer]);
assert.strictEqual(buf.byteLength, 0);
`, { eval: true });

w.on('message', common.mustCall((buf) => {
assert.notStrictEqual(buf.byteLength, 0);
}));
w.on('exit', common.mustCall());