Skip to content

quic: update deps for quic draft 29 #34033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 13 commits into from
Closed

quic: update deps for quic draft 29 #34033

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6fe4c7e
deps: update ngtcp2
jasnell Jun 23, 2020
41c4687
deps: update nghttp3
jasnell Jun 23, 2020
b872671
deps: cherry-pick akamai/openssl/commit/a6282c566d88db11300c82abc3c84…
kaduk Apr 22, 2020
c8ad923
deps: cherry-pick akamai/openssl/commit/d5a13ca6e29f3ff85c731770ab0ee…
kaduk May 11, 2020
31acd40
deps: cherry-pick akamai/openssl/commit/a5a08cb8050bb69120e833456e355…
kaduk May 11, 2020
7540e94
deps: cherry-pick akamai/openssl/commit/bf4b08ecfbb7a26ca4b0b9ecaee3b…
tatsuhiro-t May 24, 2020
1e9ff34
quic: updates to implement for h3-29
jasnell Jun 23, 2020
aed5f87
deps: temporary fixup for ngtcp2 to build on windows
jasnell Jun 23, 2020
594844f
quic: temporarily disable packetloss tests
jasnell Jun 23, 2020
db4fc01
deps: re-enable OPENSSL_NO_QUIC guards
jasnell Jun 24, 2020
26138a4
quic: possibly resolve flaky assertion failure in ipv6only test
jasnell Jun 24, 2020
5aaa9c1
quic: temporarily skip quic-ipv6only test
jasnell Jun 24, 2020
7d2a6dc
deps: fix indenting of sources in ngtcp2.gyp
jasnell Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: possibly resolve flaky assertion failure in ipv6only test
  • Loading branch information
@jasnell
jasnell committed Jun 24, 2020
commit 26138a4c2e4fb22a0dd625766063f33919865c79
11 changes: 3 additions & 8 deletions src/quic/node_quic_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1663,10 +1663,8 @@ void QuicSession::AddStream(BaseObjectPtr<QuicStream> stream) {
// not immediately torn down, but is allowed to drain
// properly per the QUIC spec description of "immediate close".
void QuicSession::ImmediateClose() {
// Calling either ImmediateClose or SilentClose will cause
// the QUICSESSION_FLAG_CLOSING to be set. In either case,
// we should never re-enter ImmediateClose or SilentClose.
CHECK(!is_flag_set(QUICSESSION_FLAG_CLOSING));
if (is_flag_set(QUICSESSION_FLAG_CLOSING))
return;
set_flag(QUICSESSION_FLAG_CLOSING);

QuicError err = last_error();
Expand Down Expand Up @@ -2368,10 +2366,7 @@ void QuicSession::ResetStream(int64_t stream_id, uint64_t code) {
// notify the JavaScript side and destroy the connection with
// a flag set that indicates stateless reset.
void QuicSession::SilentClose() {
// Calling either ImmediateClose or SilentClose will cause
// the QUICSESSION_FLAG_CLOSING to be set. In either case,
// we should never re-enter ImmediateClose or SilentClose.
CHECK(!is_flag_set(QUICSESSION_FLAG_CLOSING));
CHECK(!is_flag_set(QUICSESSION_FLAG_SILENT_CLOSE));
set_flag(QUICSESSION_FLAG_SILENT_CLOSE);
set_flag(QUICSESSION_FLAG_CLOSING);

Expand Down