Skip to content

doc: revise text in dns module documentation introduction #33986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 20 commits into from
Jun 22, 2020
Merged

doc: revise text in dns module documentation introduction #33986

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
30cc542
http: don't emit error after close
ronag May 30, 2020
51a2df4
fs: document why isPerformingIO is required
ronag Jun 19, 2020
64d22c3
timers: fix multipleResolves in promisified timeouts/immediates
lundibundi Jun 18, 2020
7a5d3a2
http: add maxTotalSockets to agent class
rickyes May 28, 2020
3de78ad
doc: use Class: consistently
Trott Jun 19, 2020
f05c963
doc: change "GitHub Repo" to "Code repository"
Trott Jun 20, 2020
07b2ada
doc: fix lexical sorting of bottom-references in dns doc
Trott Jun 20, 2020
122038c
build: add target specific build_type variable
danbev Jun 17, 2020
54374d4
src: remove unnecessary ToLocalChecked call
danbev Jun 16, 2020
b8ea471
doc: warn that tls.connect() doesn't set SNI
mildsunrise Jun 12, 2020
9743624
quic: fix typo in comments
gengjiawen Jun 19, 2020
09330fc
quic: fix clang-tidy performance-faster-string-find issue
gengjiawen Jun 19, 2020
25413b0
src: improve indention for upd_wrap.cc
gengjiawen Jun 19, 2020
74cd70e
test: fix typo in common/index.js
gengjiawen Jun 19, 2020
326a79e
test: fix typo in test-quic-client-empty-preferred-address.js
gengjiawen Jun 19, 2020
013cd1a
quic: use Check instead of FromJust in node_quic.cc
danbev Jun 18, 2020
73a7a24
doc: update fs.md
Shakil-Shahadat Jun 10, 2020
680644a
http: expose host and protocol on ClientRequest
Jun 9, 2020
8ef86a9
quic: fix clang warning
gengjiawen Jun 19, 2020
df144d2
doc: revise text in dns module documentation introduction
Trott Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: fix clang warning 
PR-URL: #33963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
@gengjiawen @jasnell
gengjiawen authored and jasnell committed Jun 22, 2020
commit 8ef86a920cda7421a8d2c6ed7cdc991ac289f58c
4 changes: 3 additions & 1 deletion src/quic/node_quic_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,9 @@ Local<Value> GetALPNProtocol(const QuicSession& session) {
QuicCryptoContext* ctx = session.crypto_context();
Environment* env = session.env();
std::string alpn = ctx->selected_alpn();
if (alpn == NGTCP2_ALPN_H3 + 1) {
// This supposed to be `NGTCP2_ALPN_H3 + 1`
// Details see https://github.com/nodejs/node/issues/33959
if (alpn == &NGTCP2_ALPN_H3[1]) {
return env->quic_alpn_string();
} else {
return ToV8Value(
Expand Down