Skip to content

timers: fix multipleResolves in promisified timeouts/immediates #33949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lundibundi wants to merge 2 commits into from
Closed

timers: fix multipleResolves in promisified timeouts/immediates #33949

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fa607f
timers: fix multipleResolves in promisified timeouts/immediates
lundibundi Jun 18, 2020
cd586a8
fixup! timers: fix multipleResolves in promisified timeouts/immediates
lundibundi Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
timers: fix multipleResolves in promisified timeouts/immediates 
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <shishugi@gmail.com>
  • Loading branch information
@lundibundi
lundibundi committed Jun 18, 2020
commit 4fa607fc7b689299d468df47df20c90c32bd09ff
12 changes: 8 additions & 4 deletions lib/timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,10 @@ setTimeout[customPromisify] = function(after, value, options = {}) {
insert(timeout, timeout._idleTimeout);
if (signal) {
signal.addEventListener('abort', () => {
clearTimeout(timeout);
reject(lazyDOMException('AbortError'));
if (!timeout._destroyed) {
clearTimeout(timeout);
reject(lazyDOMException('AbortError'));
}
}, { once: true });
}
});
Expand Down Expand Up @@ -340,8 +342,10 @@ setImmediate[customPromisify] = function(value, options = {}) {
const immediate = new Immediate(resolve, [value]);
if (signal) {
signal.addEventListener('abort', () => {
clearImmediate(immediate);
reject(lazyDOMException('AbortError'));
if (!immediate._destroyed) {
clearImmediate(immediate);
reject(lazyDOMException('AbortError'));
}
}, { once: true });
}
});
Expand Down
22 changes: 22 additions & 0 deletions test/parallel/test-timers-promisified.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ const { promisify } = require('util');
const setTimeout = promisify(timers.setTimeout);
const setImmediate = promisify(timers.setImmediate);

process.on('multipleResolves', (type, promise, reason) => {
console.error('multipleResolves', type, promise, reason);
throw new Error('multipleResolves');
});
Comment thread
lundibundi marked this conversation as resolved.
Outdated

{
const promise = setTimeout(1);
promise.then(common.mustCall((value) => {
Expand Down Expand Up @@ -66,6 +71,23 @@ const setImmediate = promisify(timers.setImmediate);
assert.rejects(setImmediate(10, { signal }), /AbortError/);
}

{
// Check that aborting after resolve will not reject.
const ac = new AbortController();
const signal = ac.signal;
setTimeout(10, undefined, { signal }).then(() => {
ac.abort();
});
}
{
// Check that aborting after resolve will not reject.
const ac = new AbortController();
const signal = ac.signal;
setImmediate(10, { signal }).then(() => {
ac.abort();
});
}

{
Promise.all(
[1, '', false, Infinity].map((i) => assert.rejects(setImmediate(10, i)), {
Expand Down