Skip to content

Fix an assertion failure at exit in the macOS app sandbox #33944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
branchseer wants to merge 5 commits into from
Closed

Fix an assertion failure at exit in the macOS app sandbox #33944

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
317621b
src: tolerate EPERM returned from tcsetattr
branchseer Jun 18, 2020
5f4f969
test: add test for running in macOS app sandbox
branchseer Jun 18, 2020
3cb770e
test: use process.execPath to get path of testing node
branchseer Jun 18, 2020
d939f7f
test: log codesign result (ci debug)
branchseer Jun 19, 2020
59e434d
Revert "test: log codesign result (ci debug)"
branchseer Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "test: log codesign result (ci debug)" 
This reverts commit d939f7f.
  • Loading branch information
@branchseer
branchseer committed Jun 19, 2020
commit 59e434d20b13d4294c71304c8a07d8704543bd46
13 changes: 4 additions & 9 deletions test/parallel/test-macos-app-sandbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,14 @@ fs.copyFileSync(


// Sign the app bundle with sandbox entitlements:
const codesignResult = child_process.spawnSync(
'/usr/bin/codesign',
[
assert.strictEqual(
child_process.spawnSync('/usr/bin/codesign', [
'--entitlements', fixtures.path(
'macos-app-sandbox', 'node_sandboxed.entitlements'),
'-s', '-',
appBundlePath
])

console.error(codesignResult)
console.error(codesignResult.stdout?.toString())
console.error(codesignResult.stderr?.toString())
assert.strictEqual(codesignResult.status, 0);
]).status,
0);

// Sandboxed app shouldn't be able to read the home dir
assert.notStrictEqual(
Expand Down