Skip to content

http2: use and support non-empty DATA frame with END_STREAM flag #33875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clshortfuse wants to merge 14 commits into from
Closed

http2: use and support non-empty DATA frame with END_STREAM flag #33875

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ca21bd1
http2: use and support non-empty DATA frame with END_STREAM flag
clshortfuse Jun 14, 2020
1e35afd
remove whitespace
clshortfuse Jun 14, 2020
30b1c06
Update node_http2.cc
clshortfuse Jun 14, 2020
6f7c361
Update node_http2.cc
clshortfuse Jun 15, 2020
cbddeb6
Update node_http2.cc
clshortfuse Jun 15, 2020
acb5999
Update node_http2.cc
clshortfuse Jun 15, 2020
85cf722
Update node_http2.cc
clshortfuse Jun 15, 2020
7bae5a5
http2: add "receive paused" debug native line
clshortfuse Jun 16, 2020
789cc1d
http2: remove empty DATA frame
clshortfuse Jun 17, 2020
0c110d0
http2: update tests
clshortfuse Jun 17, 2020
563a310
fix trailers flag detection
clshortfuse Jun 18, 2020
327e9e8
fix tests
clshortfuse Jun 18, 2020
58a3885
add test
clshortfuse Jun 18, 2020
1778fc6
add state.shutdownWritableCalled
clshortfuse Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update node_http2.cc
  • Loading branch information
@clshortfuse
clshortfuse committed Jun 18, 2020
commit 6f7c361bbf0e08045a8c916c8539d47d524fbeed
2 changes: 1 addition & 1 deletion src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ ssize_t Http2Session::OnMaxFrameSizePadding(size_t frameLen,
// quite expensive. This is a potential performance optimization target later.
ssize_t Http2Session::ConsumeHTTP2Data() {
CHECK_NOT_NULL(stream_buf_.base);
CHECK_LT(stream_buf_offset_, stream_buf_.len);
CHECK_LE(stream_buf_offset_, stream_buf_.len);
size_t read_len = stream_buf_.len - stream_buf_offset_;

// multiple side effects.
Expand Down