Skip to content

http:ClientRequest return host、protocol #33803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhangwinning wants to merge 7 commits into from
Closed

http:ClientRequest return host、protocol #33803

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4dc7ac6
http:ClientRequest return host、protocol
Jun 9, 2020
6d96e24
modify http.md
Jun 9, 2020
ce83a1a
update doc format and modify test unit
Jun 9, 2020
52500ae
modify request.method version
Jun 9, 2020
df6fcfe
remote changes section
Jun 10, 2020
62cc2af
Update test/parallel/test-http-outgoing-properties.js
Jun 22, 2020
be3c4b1
Update test/parallel/test-http-outgoing-properties.js
Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update doc format and modify test unit
  • Loading branch information
wenningplus committed Jun 9, 2020
commit ce83a1a287ed683eea3b2971a08f48c6739dfefb
6 changes: 1 addition & 5 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,11 +746,7 @@ added: v0.4.0

### `request.method`
<!-- YAML
added: REPLACEME
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33803
description: add request.method to doc.
added: v14.4.0
Comment thread
zhangwinning marked this conversation as resolved.
Outdated
-->

* {string} The request method.
Expand Down
8 changes: 3 additions & 5 deletions test/parallel/test-http-outgoing-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,12 @@ const OutgoingMessage = http.OutgoingMessage;
{
const server = http.createServer(function(req, res) {
Comment thread
zhangwinning marked this conversation as resolved.
Outdated
res.end();
res.on('finish', () => {
server.close();
});
server.close();
});

server.listen(0);

server.on('listening', function() {
server.on('listening', common.mustCall(function() {
Comment thread
zhangwinning marked this conversation as resolved.
Outdated
const req = http.request({
port: server.address().port,
method: 'GET',
Expand All @@ -74,5 +72,5 @@ const OutgoingMessage = http.OutgoingMessage;
assert.strictEqual(req.host, 'localhost');
assert.strictEqual(req.protocol, 'http:');
req.end();
});
}));
}