Skip to content

src: add "missing" bash completion options #33744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 1 commit into from
Closed

src: add "missing" bash completion options #33744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: add "missing" bash completion options 
Currently, when using the bash completions for node the normal
completions for filenames directories do not work. For example, after
using finding a node completion and then wanting to use tab completion
for a filename in the test directory it is only possible to get the name
of the test directory completed, followed by a space. What is expected
is to be able to continue with tab completion for directories.

This commit adds options to the complete command to enable default bash
completions.
  • Loading branch information
@danbev
danbev committed Jun 8, 2020
commit 43a48d376602e0cac949bd6ff5886134476d3b91
3 changes: 2 additions & 1 deletion src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,8 @@ std::string GetBashCompletion() {
" return 0\n"
" fi\n"
"}\n"
"complete -F _node_complete node node_g";
"complete -o filenames -o nospace -o bashdefault "
"-F _node_complete node node_g";
return out.str();
}

Expand Down
3 changes: 2 additions & 1 deletion test/parallel/test-bash-completion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ const suffix = `' -- "\${cur_word}") )
return 0
fi
}
complete -F _node_complete node node_g`.replace(/\r/g, '');
complete -o filenames -o nospace -o bashdefault -F _node_complete node node_g`
.replace(/\r/g, '');

assert.ok(
output.includes(prefix),
Expand Down