Skip to content

test: fix test-eventtarget #33670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lundibundi wants to merge 5 commits into from
Closed

test: fix test-eventtarget #33670

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f643cf4
event: cancelBubble is a property
benjamingr May 28, 2020
07dcb75
events: support useCapture boolean
benjamingr May 28, 2020
b2b95eb
events: set target property to null
benjamingr May 28, 2020
df4eda2
events: add event-target tests
benjamingr May 28, 2020
fdb4701
test: fix test-eventtarget
lundibundi May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
events: add event-target tests 
PR-URL: #33623
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@benjamingr
benjamingr authored and Benjamin Gruenbaum committed May 31, 2020
commit df4eda20a008530edaf7f18ff5e472b1f429c867
34 changes: 32 additions & 2 deletions test/parallel/test-eventtarget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const {
throws,
} = require('assert');

const { once } = require('events');
const { once, on } = require('events');

// The globals are defined.
ok(Event);
Expand Down Expand Up @@ -52,7 +52,7 @@ ok(EventTarget);
strictEqual(ev.type, 'foo');
}
{
const ev = new Event('foo');
const ev = new Event('foo');
strictEqual(ev.cancelBubble, false);
ev.cancelBubble = true;
strictEqual(ev.cancelBubble, true);
Expand Down Expand Up @@ -438,3 +438,33 @@ const ev = new Event('foo');
const event = new Event();
strictEqual(event.toString(), '[object Event]');
}
{
const target = new EventTarget();
const ev = new Event('toString');
const fn = common.mustCall((event) => strictEqual(event.type, 'toString'));
target.addEventListener('toString', fn);
target.dispatchEvent(ev);
}
{
const target = new EventTarget();
const ev = new Event('__proto__');
const fn = common.mustCall((event) => strictEqual(event.type, '__proto__'));
target.addEventListener('__proto__', fn);
target.dispatchEvent(ev);
}

(async () => {
// test NodeEventTarget async-iterability
const emitter = new NodeEventTarget();
const event = new Event('foo');
const interval = setInterval(() => emitter.dispatchEvent(event), 0);
let count = 0;
for await (const [ item ] of on(emitter, 'foo')) {
count++;
strictEqual(item.type, 'foo');
if (count > 5) {
break;
}
}
clearInterval(interval);
})().then(common.mustCall());