Skip to content

events: on EventTarget support + once compliance #33659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 5 commits into from
Closed

events: on EventTarget support + once compliance #33659

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62e24d9
events: fix EventTarget support
benjamingr May 30, 2020
22d784e
events: support EventTarget in on
benjamingr May 30, 2020
0f2315c
fixup! acorn doesn't like ?.
benjamingr May 30, 2020
a62ff6d
fixup! fix error listener handler case
benjamingr May 30, 2020
d783fc5
fixup! change order for listeners
May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! acorn doesn't like ?.
  • Loading branch information
@benjamingr
benjamingr committed Jun 6, 2020
commit 0f2315cafebca8ab64be4408142f337e4d79ea86
2 changes: 1 addition & 1 deletion lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ function eventTargetAgnosticAddListener(emitter, name, listener, flags) {
// EventEmitters, we do not listen to `error` events here.
emitter.addEventListener(name, (arg) => { listener(arg); }, flags);
} else if (typeof emitter.on === 'function') {
if (flags?.once) {
if (flags && flags.once) {
emitter.once(name, listener);
} else {
emitter.on(name, listener);
Expand Down