Skip to content

http: don't emit error for stream destroyed #33654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

http: don't emit error for stream destroyed #33654

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
299b2fd
http: don't emit error after close
ronag May 30, 2020
402fc26
fixup
ronag Jun 15, 2020
9f4567f
fixup
ronag Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Jun 20, 2020
commit 402fc26f0dc3a40a047a725d12f28deb9f7110c0
20 changes: 9 additions & 11 deletions test/parallel/test-http-server-write-end-after-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,19 @@ function handle(req, res) {
res.write('hello');
res.end();

setImmediate(() => {
// TODO: Known issues. OutgoingMessage does not always invoke callback
// in end. Also streams don't propagate write after end to callback.
setImmediate(common.mustCall(() => {
res.end('world');
process.nextTick(() => {
server.close();
});
// res.end('world', common.mustCall((err) => {
// common.expectsError({
// code: 'ERR_STREAM_WRITE_AFTER_END',
// name: 'Error'
// })(err);
// server.close();
// }));
});
res.write('world', common.mustCall((err) => {
common.expectsError({
code: 'ERR_STREAM_WRITE_AFTER_END',
name: 'Error'
})(err);
server.close();
}));
}));
}

server.listen(0, common.mustCall(() => {
Expand Down