Skip to content

http: add maxTotalSockets to agent class #33617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rickyes wants to merge 13 commits into from
Closed

http: add maxTotalSockets to agent class #33617

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9255fa9
http: add maxTotalSockets to agent class
rickyes May 28, 2020
958f2b3
fixup
rickyes May 28, 2020
53ce024
fixup
rickyes May 28, 2020
773d9f0
fixup
rickyes May 29, 2020
5dffb12
fixup
rickyes May 29, 2020
ca96505
fixup
rickyes May 29, 2020
154eb28
fixup
rickyes May 29, 2020
62118af
fixup
rickyes May 29, 2020
eabfaee
fixup
rickyes May 29, 2020
d7148e3
fixup
rickyes May 29, 2020
1eebc86
fixup
rickyes May 30, 2020
25b6fa5
fixup
rickyes May 30, 2020
2931fa9
fixup
rickyes May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@rickyes
rickyes committed May 29, 2020
commit eabfaee3f2a8b5c3bd216b6c73d69fe875401e4e
7 changes: 4 additions & 3 deletions lib/_http_agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,10 @@ Agent.prototype.removeSocket = function removeSocket(s, options) {
debug('removeSocket, have a request, make a socket');
req = this.requests[name][0];
} else {
Comment thread
rickyes marked this conversation as resolved.
// TODO(rickyes): this logic will not be FIFO across origins. There might be
// older requests in a different origin, but if the origin which releases
// the socket has pending requests that will be prioritized.
// TODO(rickyes): this logic will not be FIFO across origins.
// There might be older requests in a different origin, but
// if the origin which releases the socket has pending requests
// that will be prioritized.
for (const prop in this.requests) {
Comment thread
rickyes marked this conversation as resolved.
debug('removeSocket, have a request with different origin,' +
' make a socket');
Expand Down