Skip to content

events: deal with Symbol() passed to event constructor #33612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 2 commits into from
Closed

events: deal with Symbol() passed to event constructor #33612

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a2edb5
events: deal with no arguments case
May 31, 2020
56f3b58
fixup!
BridgeAR May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@BridgeAR
BridgeAR committed May 31, 2020
commit 56f3b58ca90dca3f522db6f40805cf1c8600f74b
2 changes: 1 addition & 1 deletion lib/internal/event_target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class Event {
this.#cancelable = !!cancelable;
this.#bubbles = !!bubbles;
this.#composed = !!composed;
this.#type = '' + type;
this.#type = `${type}`;
// isTrusted is special (LegacyUnforgeable)
Object.defineProperty(this, 'isTrusted', {
get() { return false; },
Expand Down