Skip to content

events: deal with no argument case #33611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 5 commits into from
+15 −2
Closed

events: deal with no argument case #33611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7373159
events: deal with no argument case
benjamingr May 28, 2020
a1a4326
fixup! arguments
benjamingr May 28, 2020
df00bc0
fixup! lint
benjamingr May 28, 2020
0b740f6
fixup! use ERR_MISSING_ARGS
benjamingr May 28, 2020
9e77c56
fixup! fix test
benjamingr Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
events: deal with no argument case
  • Loading branch information
@benjamingr
benjamingr committed Jun 4, 2020
commit 73731593fd53e8a80b429844bd35bc92bf53f7cf
5 changes: 5 additions & 0 deletions doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,11 @@ Encoding provided to `TextDecoder()` API was not one of the

Thrown when an attempt is made to recursively dispatch an event on `EventTarget`.

<a id="ERR_EVENT_NAME_REQUIRED"></a>
### `ERR_EVENT_NAME_REQUIRED`

Thrown when an Event is created without passing its constructor a valid `type`.

<a id="ERR_EXECUTION_ENVIRONMENT_NOT_AVAILABLE"></a>
### `ERR_EXECUTION_ENVIRONMENT_NOT_AVAILABLE`

Expand Down
2 changes: 2 additions & 0 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,6 +831,8 @@ E('ERR_ENCODING_NOT_SUPPORTED', 'The "%s" encoding is not supported',
RangeError);
E('ERR_EVAL_ESM_CANNOT_PRINT', '--print cannot be used with ESM input', Error);
E('ERR_EVENT_RECURSION', 'The event "%s" is already being dispatched', Error);
E('ERR_EVENT_NAME_REQUIRED', 'The event constructor must be called with at' +
'least 1 argument.', TypeError);
E('ERR_FALSY_VALUE_REJECTION', function(reason) {
this.reason = reason;
return 'Promise was rejected with falsy value';
Expand Down
4 changes: 4 additions & 0 deletions lib/internal/event_target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const {
ERR_INVALID_ARG_TYPE,
ERR_EVENT_RECURSION,
ERR_OUT_OF_RANGE,
ERR_EVENT_NAME_REQUIRED
}
} = require('internal/errors');

Expand Down Expand Up @@ -45,6 +46,9 @@ class Event {


constructor(type, options) {
if (arguments.length === 0) {
throw new ERR_EVENT_NAME_REQUIRED();
Comment thread
BridgeAR marked this conversation as resolved.
Outdated
}
if (options != null && typeof options !== 'object')
throw new ERR_INVALID_ARG_TYPE('options', 'object', options);
const { cancelable, bubbles, composed } = { ...options };
Expand Down
6 changes: 6 additions & 0 deletions test/parallel/test-eventtarget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ ok(EventTarget);
strictEqual(ev.defaultPrevented, false);
strictEqual(typeof ev.timeStamp, 'number');

// no argument behavior
throws(() => {
new Event();
}, TypeError);

// compatibility properties with the DOM
deepStrictEqual(ev.composedPath(), []);
strictEqual(ev.returnValue, true);
strictEqual(ev.bubbles, false);
Expand Down