Remove prending deprecation for backporting

nodejs · aduh95 · Mar 11, 2020 · May 24, 2020 · Jul 14, 2020 · Jul 14, 2020
commit c88cca4b48d03ffa24731b0dc7c631b0e557f50d
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -2704,7 +2704,7 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only (supports [`--pending-deprecation`][])
+Type: Documentation-only
 
 A CommonJS module can access the first module that required it using
 `module.parent`. This feature is deprecated because it does not work

diff --git a/doc/api/modules.md b/doc/api/modules.md
@@ -690,6 +690,7 @@ Module {
   id: '.',
   path: '/absolute/path/to',
   exports: {},
+  parent: null,
   filename: '/absolute/path/to/entry.js',
   loaded: false,
   children: [],
@@ -903,7 +904,7 @@ deprecated: REPLACEME
 
 The module that first required this one, or `null` if the current module is the
 entry point of the current process, or `undefined` if the module was loaded by
-something that is not a CommonJS module (E.G.: REPL or `import`). Read only.
+something that is not a CommonJS module (E.G.: REPL or `import`).
 
 ### `module.path`
 <!-- YAML

diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -39,7 +39,6 @@ const {
   ReflectSet,
   RegExpPrototypeTest,
   SafeMap,
-  SafeWeakMap,
   String,
   StringPrototypeIndexOf,
   StringPrototypeMatch,
@@ -160,12 +159,11 @@ function updateChildren(parent, child, scan) {
     children.push(child);
 }
 
-const moduleParentCache = new SafeWeakMap();
 function Module(id = '', parent) {
   this.id = id;
   this.path = path.dirname(id);
   this.exports = {};
-  moduleParentCache.set(this, parent);
+  this.parent = parent;
   updateChildren(parent, this, false);
   this.filename = null;
   this.loaded = false;
@@ -234,18 +232,6 @@ ObjectDefineProperty(Module, 'wrapper', {
   }
 });
 
-function getModuleParent() {
-  return moduleParentCache.get(this);
-}
-ObjectDefineProperty(Module.prototype, 'parent', {
-  get: pendingDeprecation ? deprecate(
-    getModuleParent,
-    'module.parent is deprecated due to accuracy issues. Please use ' +
-      'require.main to find program entry point instead.',
-    'DEP0143'
-  ) : getModuleParent
-});
-
 const debug = require('internal/util/debuglog').debuglog('module');
 Module._debug = deprecate(debug, 'Module._debug is deprecated.', 'DEP0077');
 
@@ -1032,7 +1018,7 @@ Module._resolveFilename = function(request, parent, isMain, options) {
   const requireStack = [];
   for (let cursor = parent;
     cursor;
-    cursor = moduleParentCache.get(cursor)) {
+    cursor = cursor.parent) {
     requireStack.push(cursor.filename || cursor.id);
   }
   let message = `Cannot find module '${request}'`;
@@ -1225,7 +1211,7 @@ Module._extensions['.js'] = function(module, filename) {
     const pkg = readPackageScope(filename);
     // Function require shouldn't be used in ES modules.
     if (pkg && pkg.data && pkg.data.type === 'module') {
-      const parent = moduleParentCache.get(module);
+      const { parent } = module;
       const parentPath = parent && parent.filename;
       const packageJsonPath = path.resolve(pkg.path, 'package.json');
       throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);

diff --git a/test/parallel/test-module-parent-deprecation.js b/test/parallel/test-module-parent-deprecation.js