Skip to content

wasi: refactor and enable poll_oneoff() test #33521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 2 commits into from
May 25, 2020
Merged

wasi: refactor and enable poll_oneoff() test #33521

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d2d210
deps: uvwasi: cherry-pick 9e75217
cjihrig May 23, 2020
a4e6ef7
wasi: refactor and enable poll_oneoff() test
cjihrig May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: uvwasi: cherry-pick 9e75217 
Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed May 25, 2020
commit 2d2d210db7ebf554c310dc1196c44ba30976d0f0
2 changes: 2 additions & 0 deletions deps/uvwasi/src/poll_oneoff.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ uvwasi_errno_t uvwasi__poll_oneoff_state_cleanup(
for (i = 0; i < state->handle_cnt; i++)
uv_close((uv_handle_t*) &state->poll_handles[i], NULL);

uv_run(&state->loop, UV_RUN_NOWAIT);

state->max_fds = 0;
state->fdevent_cnt = 0;
state->handle_cnt = 0;
Expand Down