Skip to content

crypto: fix wrong error message #33482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benbucksch wants to merge 5 commits into from
Closed

crypto: fix wrong error message #33482

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b55a43b
crypto: fix wrong error message
benbucksch May 20, 2020
0fb7721
Adapt test to new error message
benbucksch May 20, 2020
8b06217
Review comment
benbucksch May 20, 2020
2148e9a
Adapt tests
benbucksch May 20, 2020
c4a3d0c
NIT: Remove unnecessary change
benbucksch May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/crypto/keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,10 @@ function prepareAsymmetricKey(key, ctx) {
// Either PEM or DER using PKCS#1 or SPKI.
if (!isStringOrBuffer(data)) {
throw new ERR_INVALID_ARG_TYPE(
'key',
'key.key property',
Comment thread
himself65 marked this conversation as resolved.
Outdated
['string', 'Buffer', 'TypedArray', 'DataView',
...(ctx !== kCreatePrivate ? ['KeyObject'] : [])],
key);
data);
}

const isPublic =
Expand Down