Skip to content

dns: make dns.Resolver timeout configurable #33472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 4 commits into from
Closed

dns: make dns.Resolver timeout configurable #33472

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a089864
dns: make dns.Resolver timeout configurable
bnoordhuis May 19, 2020
b4cac47
fixup! update pr-url
bnoordhuis May 19, 2020
eae2cfc
fixup! clamp timeout at 1000 ms
bnoordhuis May 19, 2020
7941e84
Update lib/internal/dns/utils.js
bnoordhuis May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! clamp timeout at 1000 ms 
otherwise it's a possible observable change in behavior
  • Loading branch information
@bnoordhuis
bnoordhuis committed May 19, 2020
commit eae2cfc7e1260b75a39c51f9984a7200de96f282
2 changes: 1 addition & 1 deletion src/cares_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ void ChannelWrap::StartTimer() {
}
int timeout = timeout_;
if (timeout == 0) timeout = 1;
if (timeout < 0) timeout = 1000;
if (timeout < 0 || timeout > 1000) timeout = 1000;
uv_timer_start(timer_handle_, AresTimeout, timeout, timeout);
}

Expand Down