Skip to content

fs: readdir fails when libuv returns UV_DIRENT_UNKNOWN and the first arg is Buffer #33395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shackijj wants to merge 5 commits into from
Closed

fs: readdir fails when libuv returns UV_DIRENT_UNKNOWN and the first arg is Buffer #33395

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0cfa197
fs: test readdir with a buffer as a first param
shackijj May 14, 2020
a5328e2
fs: test readdir on macOS only
shackijj May 19, 2020
544ef53
fs: add tests for get-dirents
shackijj May 19, 2020
e6d39b3
fs: add join function which takes Buffers and strings as args
shackijj Jun 13, 2020
0435053
fs: add a space
shackijj Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fs: test readdir with a buffer as a first param 
Refs: #33348
  • Loading branch information
@shackijj
shackijj committed Jun 13, 2020
commit 0cfa1975f798c2ccfa1308c87f437f182f1776cb
17 changes: 17 additions & 0 deletions test/parallel/test-fs-readdir-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
'use strict';
const fs = require('fs');

const common = require('../common');
if (common.isWindows) {
common.skip('windows doesnt support /dev');
}

const assert = require('assert');

fs.readdir(
Buffer.from("/dev"),
{withFileTypes: true, encoding: "buffer"},
common.mustCall((e,d) => {
assert.strictEqual(e, null);
})
);