Skip to content

worker: fix crash when .unref() is called during exit #33394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

worker: fix crash when .unref() is called during exit #33394

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ea7484
worker: fix crash when .unref() is called during exit
addaleax May 14, 2020
e010141
fixup! worker: fix crash when .unref() is called during exit
addaleax May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! worker: fix crash when .unref() is called during exit
  • Loading branch information
@addaleax
addaleax committed May 14, 2020
commit e010141eb7a1f86f898f355e8986edcbd2ca319e
3 changes: 3 additions & 0 deletions test/parallel/test-worker-unref-from-message-during-exit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
const common = require('../common');
const { Worker } = require('worker_threads');

Comment thread
addaleax marked this conversation as resolved.
// This used to crash because the `.unref()` was unexpected while the Worker
// was exiting.

const w = new Worker(`
require('worker_threads').parentPort.postMessage({});
`, { eval: true });
Expand Down