Skip to content

stream: Duplex forward writableObjectMode #33390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: Duplex forward writableObjectMode #33390

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3326255
stream: Duplex forward writableObjectMode
ronag May 13, 2020
de35e4f
fixup! stream: Duplex forward writableObjectMode
ronag May 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! stream: Duplex forward writableObjectMode
  • Loading branch information
@ronag
ronag committed May 17, 2020
commit de35e4fabaca74ec54a8116b79f4d39642db4811
4 changes: 3 additions & 1 deletion test/parallel/test-stream-duplex-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@ const assert = require('assert');
const { Duplex } = require('stream');

{
const d = new Duplex({
const d = new Duplex({
objectMode: true,
highWaterMark: 100
});

assert.strictEqual(d.writableObjectMode, true);
assert.strictEqual(d.writableHighWaterMark, 100);
Comment thread
ronag marked this conversation as resolved.
assert.strictEqual(d.readableObjectMode, true);
assert.strictEqual(d.readableHighWaterMark, 100);
}

{
Expand Down