Skip to content

doc: update readline key-bindings and TODO comments #33361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

doc: update readline key-bindings and TODO comments #33361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c78606f
doc: fix readline key binding documentation
BridgeAR May 11, 2020
63b5734
doc: update TODO comments
BridgeAR May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: update TODO comments 
This removes one TODO comment and adds another that indicates that
readline is currently not able to trigger specific escape sequences.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@BridgeAR
BridgeAR committed May 11, 2020
commit 63b57343757e539ad5c8b65bbf9f47791849f241
6 changes: 5 additions & 1 deletion lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,8 @@ Interface.prototype._ttyWrite = function(s, key) {
if (key.ctrl && key.shift) {
/* Control and shift pressed */
switch (key.name) {
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
// identical to <ctrl>-h. It should have a unique escape sequence.
case 'backspace':
this._deleteLineLeft();
break;
Expand Down Expand Up @@ -952,8 +954,10 @@ Interface.prototype._ttyWrite = function(s, key) {
}
break;

// TODO(BridgeAR): This seems broken?
case 'w': // Delete backwards to a word boundary
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
// identical to <ctrl>-h. It should have a unique escape sequence.
// Falls through
case 'backspace':
this._deleteWordLeft();
break;
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-assert-deep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,8 +957,6 @@ assertDeepAndStrictEqual(obj1, obj2);

// Check proxies.
{
// TODO(BridgeAR): Check if it would not be better to detect proxies instead
// of just using the proxy value.
const arrProxy = new Proxy([1, 2], {});
assert.deepStrictEqual(arrProxy, [1, 2]);
const tmp = util.inspect.defaultOptions;
Expand Down