Skip to content

async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabled #33347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabled #33347

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b523a31
worker: call CancelTerminateExecution() before exiting Locker
addaleax May 10, 2020
d90c3d1
async_hooks: clear async_id_stack for terminations in more places
addaleax May 11, 2020
7b45371
test: regression tests for async_hooks + Promise + Worker interaction
addaleax May 10, 2020
3d9d564
fixup! test: regression tests for async_hooks + Promise + Worker inte…
addaleax May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
worker: call CancelTerminateExecution() before exiting Locker 
As the comment indicates, this fixes a DCHECK failure, although I don’t
quite understand why it is happening in the first place.
  • Loading branch information
@addaleax
addaleax committed May 10, 2020
commit b523a314bb3759b7d5d1aac8d472bfe16c3c33f4
5 changes: 5 additions & 0 deletions src/node_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,11 @@ void Worker::Run() {

DeleteFnPtr<Environment, FreeEnvironment> env_;
auto cleanup_env = OnScopeLeave([&]() {
// TODO(addaleax): This call is harmless but should not be necessary.
// Figure out why V8 is raising a DCHECK() here without it
// (in test/parallel/test-async-hooks-worker-asyncfn-terminate-4.js).
isolate_->CancelTerminateExecution();

if (!env_) return;
env_->set_can_call_into_js(false);

Expand Down