Skip to content

test: fix test-net-throttle #33329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
May 11, 2020
Merged

test: fix test-net-throttle #33329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix test-net-throttle 
Repeat writes until data is queued in memory, rather than assuming that
it will happen by a certain point.

Fixes: #33135

PR-URL: #33329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
  • Loading branch information
@Trott
Trott committed May 11, 2020
commit 5ded044deaad44ea4b87b321e02190cdb12fe33a
41 changes: 25 additions & 16 deletions test/pummel/test-net-throttle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,44 +23,53 @@
require('../common');
const assert = require('assert');
const net = require('net');
const debuglog = require('util').debuglog('test');

const N = 1024 * 1024;
const part_N = N / 3;
let chars_recved = 0;
let npauses = 0;

console.log('build big string');
const body = 'C'.repeat(N);
let totalLength = 0;

const server = net.createServer((connection) => {
connection.write(body.slice(0, part_N));
connection.write(body.slice(part_N, 2 * part_N));
assert.strictEqual(connection.write(body.slice(2 * part_N, N)), false);
console.log(`bufferSize: ${connection.bufferSize}`, 'expecting', N);
assert.ok(connection.bufferSize >= 0 &&
connection.writableLength <= N);
const body = 'C'.repeat(1024);
let n = 1;
debuglog('starting write loop');
while (connection.write(body)) {
n++;
}
debuglog('ended write loop');
// Now that we're throttled, do some more writes to make sure the data isn't
// lost.
connection.write(body);
connection.write(body);
n += 2;
totalLength = n * body.length;
assert.ok(connection.bufferSize >= 0, `bufferSize: ${connection.bufferSize}`);
assert.ok(
connection.writableLength <= totalLength,
`writableLength: ${connection.writableLength}, totalLength: ${totalLength}`
);
connection.end();
});

server.listen(0, () => {
const port = server.address().port;
console.log(`server started on port ${port}`);
debuglog(`server started on port ${port}`);
let paused = false;
const client = net.createConnection(port);
client.setEncoding('ascii');
client.on('data', (d) => {
chars_recved += d.length;
console.log(`got ${chars_recved}`);
debuglog(`got ${chars_recved}`);
if (!paused) {
client.pause();
npauses += 1;
paused = true;
console.log('pause');
debuglog('pause');
const x = chars_recved;
setTimeout(() => {
assert.strictEqual(chars_recved, x);
client.resume();
console.log('resume');
debuglog('resume');
paused = false;
}, 100);
}
Expand All @@ -74,6 +83,6 @@ server.listen(0, () => {


process.on('exit', () => {
assert.strictEqual(chars_recved, N);
assert.strictEqual(chars_recved, totalLength);
assert.strictEqual(npauses > 2, true);
});