Skip to content

Revert tls.rootCertificates implementation and correct documentation #33313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebickle wants to merge 2 commits into from
Closed

Revert tls.rootCertificates implementation and correct documentation #33313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56a430a
Revert "src: fix missing extra ca in tls.rootCertificates"
ebickle May 8, 2020
3a65605
doc: correct tls.rootCertificates to match implementation
ebickle May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: correct tls.rootCertificates to match implementation 
Update tls.rootCertificates documentation to clarify that it returns
the bundled Node.js root certificates rather than the root certificates used by tls.createSecureContext.

Fixes: #32074
Refs: #32229
  • Loading branch information
@ebickle
ebickle committed May 8, 2020
commit 3a65605b22238703b891e5943860ceb56bd25545
6 changes: 4 additions & 2 deletions doc/api/tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1791,8 +1791,10 @@ added: v12.3.0
* {string[]}

An immutable array of strings representing the root certificates (in PEM format)
used for verifying peer certificates. This is the default value of the `ca`
option to [`tls.createSecureContext()`][].
from the bundled Mozilla CA store as supplied by current Node.js version.

The bundled CA store, as supplied by Node.js, is a snapshot of Mozilla CA store
that is fixed at release time. It is identical on all supported platforms.

## `tls.DEFAULT_ECDH_CURVE`
<!-- YAML
Expand Down