Skip to content

repl: improve repl preview #33282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 8 commits into from
Closed

repl: improve repl preview #33282

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
210aee2
repl: improve repl preview
BridgeAR May 4, 2020
733baf1
repl: show reference errors during preview
BridgeAR May 4, 2020
a62e2b2
repl: replace hard coded core module list with actual list
BridgeAR May 7, 2020
c24445d
test: refactor test/parallel/test-bootstrap-modules.js
BridgeAR May 7, 2020
00cd4d8
repl: improve repl autocompletion for require calls
BridgeAR May 7, 2020
abc2bda
fixup! repl: show reference errors during preview
BridgeAR May 11, 2020
2e04c5d
fixup! repl: show reference errors during preview
BridgeAR May 14, 2020
e8294cf
fixup! repl: improve repl autocompletion for require calls
BridgeAR May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: refactor test/parallel/test-bootstrap-modules.js 
This simplifies the test a bit by removing duplicated code and by
focusing the reader on the passed through module.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@BridgeAR
BridgeAR committed May 7, 2020
commit c24445d21e7b9854995ef41986397d48cb9aec24
42 changes: 22 additions & 20 deletions test/parallel/test-bootstrap-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,26 +85,28 @@ const expectedModules = new Set([
]);

if (!common.isMainThread) {
expectedModules.add('Internal Binding messaging');
expectedModules.add('Internal Binding symbols');
expectedModules.add('Internal Binding worker');
expectedModules.add('NativeModule _stream_duplex');
expectedModules.add('NativeModule _stream_passthrough');
expectedModules.add('NativeModule _stream_readable');
expectedModules.add('NativeModule _stream_transform');
expectedModules.add('NativeModule _stream_writable');
expectedModules.add('NativeModule internal/error-serdes');
expectedModules.add('NativeModule internal/process/worker_thread_only');
expectedModules.add('NativeModule internal/streams/buffer_list');
expectedModules.add('NativeModule internal/streams/destroy');
expectedModules.add('NativeModule internal/streams/end-of-stream');
expectedModules.add('NativeModule internal/streams/legacy');
expectedModules.add('NativeModule internal/streams/pipeline');
expectedModules.add('NativeModule internal/streams/state');
expectedModules.add('NativeModule internal/worker');
expectedModules.add('NativeModule internal/worker/io');
expectedModules.add('NativeModule stream');
expectedModules.add('NativeModule worker_threads');
[
'Internal Binding messaging',
'Internal Binding symbols',
'Internal Binding worker',
'NativeModule _stream_duplex',
'NativeModule _stream_passthrough',
'NativeModule _stream_readable',
'NativeModule _stream_transform',
'NativeModule _stream_writable',
'NativeModule internal/error-serdes',
'NativeModule internal/process/worker_thread_only',
'NativeModule internal/streams/buffer_list',
'NativeModule internal/streams/destroy',
'NativeModule internal/streams/end-of-stream',
'NativeModule internal/streams/legacy',
'NativeModule internal/streams/pipeline',
'NativeModule internal/streams/state',
'NativeModule internal/worker',
'NativeModule internal/worker/io',
'NativeModule stream',
'NativeModule worker_threads',
].forEach(expectedModules.add.bind(expectedModules));
}

if (common.hasIntl) {
Expand Down