Skip to content

doc: add warning for socket.connect reuse #33204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

doc: add warning for socket.connect reuse #33204

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76bf3dd
doc: deprecate socket.connect
ronag May 1, 2020
3293954
Revert "doc: deprecate socket.connect"
ronag May 5, 2020
11ae8f4
doc: add warning for socket.connect reuse
ronag May 5, 2020
74430ce
fixup
ronag May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@ronag
ronag committed May 6, 2020
commit 74430ce8a2e8abdfc427c2ccb0aae85aace4b265
6 changes: 3 additions & 3 deletions doc/api/net.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,9 +600,9 @@ the error passed to the [`'error'`][] listener.
The last parameter `connectListener`, if supplied, will be added as a listener
for the [`'connect'`][] event **once**.

This function should not be used for reconnecting a socket. Calling
[`socket.connect()`][] a second time leads to undefined behavior.
[`net.connect()`][] implicitly calls [`socket.connect()`][].
This function should only be used for reconnecting a socket after
`'close'` has been emitted or otherwise it may lead to undefined
behavior.

#### `socket.connect(options[, connectListener])`
<!-- YAML
Expand Down