Skip to content

Feature/fix freebsd build #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 8 commits into from
Closed

Feature/fix freebsd build #332

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9977e8
deps: fix v8 build on FreeBSD
indutny Jan 13, 2015
9645fc2
cares: 0-ify AI_V4MAPPED on FreeBSD
indutny Jan 13, 2015
c731055
test: loosen timeout in spawnsync-test for FreeBSD
indutny Jan 13, 2015
36c79c7
test: fix setproctitle on FreeBSD
indutny Jan 13, 2015
4e458d7
test: disable fs-readfile-error on FreeBSD
indutny Jan 13, 2015
60a62a8
v4mapped
indutny Jan 13, 2015
22dd5a9
test-readfile
indutny Jan 13, 2015
0ac4ee3
dns: proper comment
indutny Jan 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
dns: proper comment
  • Loading branch information
@indutny
indutny committed Jan 13, 2015
commit 0ac4ee31c8ac26304c7416edbcf9d2ac2db4860c
4 changes: 3 additions & 1 deletion lib/dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ exports.lookup = function lookup(hostname, options, callback) {
throw new TypeError('invalid argument: hints must use valid flags');
}

if (process.platform === 'freebsd' || family !== 6)
// FIXME(indutny): V4MAPPED on FreeBSD results in EAI_BADFLAGS, because
// the kernel does not support it
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Jan 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close enough, I guess. (It's libc, not the kernel. Details...)

if (process.platform === 'freebsd' && family !== 6)
hints &= ~exports.V4MAPPED;
} else {
family = options >>> 0;
Expand Down