Skip to content

http2: check for valid headers #33193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexagod wants to merge 6 commits into from
Closed

http2: check for valid headers #33193

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
388915a
http2: header field valid checks
rexagod May 1, 2020
d092e96
fixup: remove unnecessary error
rexagod May 2, 2020
a0575e0
test: add checks for writeHead
rexagod May 10, 2020
502c549
fixup: lint
rexagod May 10, 2020
49f5092
Update lib/internal/http2/core.js
rexagod May 23, 2020
32689ba
fixup: review suggestions
rexagod May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add checks for writeHead
  • Loading branch information
@rexagod
rexagod committed May 10, 2020
commit a0575e048d0b03e16e4696df23a185d33f2a06ed
24 changes: 24 additions & 0 deletions test/parallel/test-http2-invalidheaderfields-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const server1 = http2.createServer();

server1.listen(0, common.mustCall(() => {
const session = http2.connect(`http://localhost:${server1.address().port}`);
// check for req headers
session.request({ 'no underscore': 123 });
session.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'ERR_INVALID_HTTP_TOKEN');
Expand All @@ -16,6 +17,7 @@ server1.listen(0, common.mustCall(() => {
}));

const server2 = http2.createServer(common.mustCall((req, res) => {
// check for setHeader
res.setHeader('x y z', 123);
res.end();
}));
Expand All @@ -29,3 +31,25 @@ server2.listen(0, common.mustCall(() => {
server2.close();
}));
}));

const server3 = http2.createServer(common.mustCall((req, res) => {
// check for writeHead
assert.throws(common.mustCall(()=>{
res.writeHead(200, {
'an invalid header': 123
});
}), {
code: 'ERR_HTTP2_INVALID_STREAM'
});
res.end();
}));

server3.listen(0, common.mustCall(() => {
const session = http2.connect(`http://localhost:${server3.address().port}`);
const req = session.request();
req.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'ERR_HTTP2_STREAM_ERROR');
server3.close();
session.close();
}));
}));