Skip to content

http2: avoid Object.create(null) for Http2ServerRequest.headers #33183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexagod wants to merge 4 commits into from
Closed

http2: avoid Object.create(null) for Http2ServerRequest.headers #33183

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fce18c
http2: comment on usage of `Object.create(null)`
rexagod Apr 25, 2020
9870173
nit
rexagod May 2, 2020
e617dd2
fixup: lint error
rexagod May 9, 2020
cacf9cd
fixup: lint error
rexagod May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,10 @@ class Http2ServerRequest extends Readable {
closed: false,
didRead: false,
};
// headers in HTTP/1 are not initialized using Object.create(null)
// which, although preferable, would simply break too much code.
// Ergo, header initialization using Object.create(null) in HTTP/2
// is intentional.
this[kHeaders] = headers;
this[kRawHeaders] = rawHeaders;
this[kTrailers] = {};
Expand Down