Skip to content

http: destroy timeout socket by Agent #33177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 10 commits into from
Closed

http: destroy timeout socket by Agent #33177

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2e94eea
http: set default timeout in agent keepSocketAlive
omsmith Apr 28, 2020
f27a327
Apply suggestions from code review
ronag May 3, 2020
30e5e6e
Update doc/api/http.md
ronag May 3, 2020
71e011b
fixup
ronag May 3, 2020
6e9aa05
fixup
ronag May 3, 2020
756b28e
fixup
ronag May 3, 2020
c36bf11
fixup
ronag May 4, 2020
5d840c6
Update test/parallel/test-gc-http-client-timeout.js
ronag May 8, 2020
380bed1
fixup
ronag May 10, 2020
56cae43
fixup
ronag May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/parallel/test-gc-http-client-timeout.js 
Co-authored-by: Denys Otrishko <shishugi@gmail.com>
  • Loading branch information
@ronag @lundibundi
ronag and lundibundi committed May 10, 2020
commit 5d840c6a4646c92e1b942f2a4a1f6eb2c7536750
2 changes: 1 addition & 1 deletion test/parallel/test-gc-http-client-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function getall() {
console.log('timeout (expected)');
});
req.on('error', common.expectsError({
// Only allow Socket timeout error
// Only allow Socket timeout error.
code: 'ERR_HTTP_SOCKET_TIMEOUT',
message: 'Socket timeout'
}));
Expand Down