Skip to content

http2: add bytesWritten test for Http2Stream #33162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexagod wants to merge 2 commits into from
Closed

http2: add bytesWritten test for Http2Stream #33162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b004027
http2: add `bytesWritten` test for `Http2Stream`
rexagod Apr 21, 2020
e691fd3
don't use PerformanceObserver API
rexagod May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
don't use PerformanceObserver API
  • Loading branch information
@rexagod
rexagod committed May 2, 2020
commit e691fd33a21752997befae24cef38165713130cc
21 changes: 6 additions & 15 deletions test/parallel/test-http2-byteswritten-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,24 @@ if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const { PerformanceObserver } = require('perf_hooks');

const http2Server = http2.createServer(common.mustCall(function(req, res) {
res.socket.on('finish', common.mustCall(() => {
assert(req.socket.bytesWritten > 0); // 1094
}));
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.end(Buffer.from('9'.repeat(1024)), () => {
http2Server.close();
});
res.write(Buffer.from('1'.repeat(1024)));
res.end();
}));

http2Server.listen(0, common.mustCall(function() {
const URL = `http://localhost:${http2Server.address().port}`;
const http2client = http2.connect(URL, { protocol: 'http:' });
const req = http2client.request({ ':method': 'GET', ':path': '/' });
req.on('response', common.mustCall());
req.on('data', common.mustCall());
req.on('end', common.mustCall(function() {
http2client.close();
observer.disconnect();
http2Server.close();
}));
req.end();
}));

const observer = new PerformanceObserver(common.mustCall(function(items) {
const entry = items.getEntries()[0];
if (entry.name === 'Http2Stream') {
assert.strictEqual(entry.bytesWritten, 1024);
}
}));

observer.observe({ entryTypes: ['http2'] });