Skip to content

http2: allow explicity setting date headers #33160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexagod wants to merge 3 commits into from
+36 −1
Closed

http2: allow explicity setting date headers #33160

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0825806
http2: do not modify explicity set date headers
rexagod Apr 25, 2020
7cb1a7d
fixup: add YAML logs
rexagod May 2, 2020
c900603
Apply suggestions from code review
rexagod May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: add YAML logs
  • Loading branch information
@rexagod
rexagod committed May 2, 2020
commit 7cb1a7d00e8a0b61030d5f28497aba4f5ce3ec7b
10 changes: 10 additions & 0 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,6 +1406,10 @@ and will throw an error.
#### `http2stream.respond([headers[, options]])`
<!-- YAML
added: v8.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33160
description: Allow explicity setting date headers.
-->

* `headers` {HTTP/2 Headers Object}
Expand Down Expand Up @@ -1450,6 +1454,9 @@ server.on('stream', (stream) => {
<!-- YAML
added: v8.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33160
description: Allow explicity setting date headers.
- version: v12.12.0
pr-url: https://github.com/nodejs/node/pull/29876
description: The `fd` option may now be a `FileHandle`.
Expand Down Expand Up @@ -1548,6 +1555,9 @@ server.on('stream', (stream) => {
<!-- YAML
added: v8.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33160
description: Allow explicity setting date headers.
- version: v10.0.0
pr-url: https://github.com/nodejs/node/pull/18936
description: Any readable file, not necessarily a
Expand Down