Skip to content

http: don't throw on Uint8Arrays for http.ServerResponse#write #33155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexagod wants to merge 2 commits into from
Closed

http: don't throw on Uint8Arrays for http.ServerResponse#write #33155

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4d9b2
http: don't throw on `Uint8Array`s for `http.ServerResponse#write`
rexagod May 3, 2020
cf914d5
fixup: lint
rexagod May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: lint
  • Loading branch information
@rexagod
rexagod committed May 10, 2020
commit cf914d5dc7d5bd44e4555c728346d180fb66f66f
2 changes: 1 addition & 1 deletion lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const {
hideStackFrames
} = require('internal/errors');
const { validateString } = require('internal/validators');
const{ isUint8Array } = require('internal/util/types');
const { isUint8Array } = require('internal/util/types');

const HIGH_WATER_MARK = getDefaultHighWaterMark();
const { CRLF, debug } = common;
Expand Down