Skip to content

test: [http] throw on arrays for Http2ServerResponse.end #33146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexagod wants to merge 9 commits into from
Closed

test: [http] throw on arrays for Http2ServerResponse.end #33146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f08186
http2: add type checks for Http2ServerResponse.end
rexagod Apr 26, 2020
dd62977
fixup
rexagod Apr 30, 2020
4ef609a
fixup: drop Buffer checks
rexagod Apr 30, 2020
850384a
fixup: lint error
rexagod Apr 30, 2020
f7a974e
fixup: add Uint8Array to valid types
rexagod Apr 30, 2020
26efdc5
fixup: dont modify HTTP2 code and remove unnecessary test
rexagod May 3, 2020
eb1dffc
add test
rexagod May 10, 2020
b19e351
rebase
rexagod May 10, 2020
4373ed1
fixup: remove changes from _http_outgoing.js
rexagod May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: dont modify HTTP2 code and remove unnecessary test
  • Loading branch information
@rexagod
rexagod committed May 23, 2020
commit 26efdc5a5073cfcb2ce831599a174f1c85dcb59f
18 changes: 2 additions & 16 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const {
ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED,
ERR_HTTP2_STATUS_INVALID,
ERR_INVALID_ARG_VALUE,
ERR_INVALID_ARG_TYPE,
ERR_INVALID_CALLBACK,
ERR_INVALID_HTTP_TOKEN,
ERR_STREAM_WRITE_AFTER_END
Expand All @@ -48,7 +47,6 @@ const {
} = require('internal/errors');
const { validateString } = require('internal/validators');
const { kSocket, kRequest, kProxySocket } = require('internal/http2/util');
const { isUint8Array } = require('internal/util/types');

const kBeginSend = Symbol('begin-send');
const kState = Symbol('state');
Expand Down Expand Up @@ -700,20 +698,8 @@ class Http2ServerResponse extends Stream {
encoding = 'utf8';
}

if (chunk !== null && chunk !== undefined) {
if (typeof chunk === 'string' ||
(isUint8Array(chunk))) {
this.write(chunk, encoding);
} else {
// Will not be forwarded to Http2ServerResponse object
// since this behavior is not allowed in compat mode
const err = new ERR_INVALID_ARG_TYPE('chunk',
['string', 'Buffer', 'Uint8Array'],
chunk);
// Throws an ERR_HTTP2_STREAM_ERROR error
this.destroy(err);
}
}
if (chunk !== null && chunk !== undefined)
this.write(chunk, encoding);

state.headRequest = stream.headRequest;
state.ending = true;
Expand Down
20 changes: 0 additions & 20 deletions test/parallel/test-http2-res-end-types.js
View file
Open in desktop

This file was deleted.