Skip to content

stream: fix stream.finished on Duplex #33133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 11 commits into from
Closed

stream: fix stream.finished on Duplex #33133

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
45c27c6
stream: fix stream.finished on Duplex
ronag Apr 28, 2020
bfd17cd
fixup: test
ronag Apr 28, 2020
5bd8e7c
fixup: test
ronag Apr 28, 2020
02be7f3
fixup: test
ronag Apr 28, 2020
9b83b7e
fixup: test
ronag Apr 28, 2020
327dcb3
fixup: test
ronag Apr 28, 2020
1fc6c3e
fixup: test
ronag Apr 28, 2020
20fe402
fixup: test
ronag Apr 28, 2020
8cab4dd
fixup: test
ronag Apr 28, 2020
882f704
fixup: simplify according to suggestion
ronag Apr 29, 2020
c7899a9
Revert "fixup: simplify according to suggestion"
ronag Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: test
  • Loading branch information
@ronag
ronag committed Apr 28, 2020
commit 20fe402464c3af07cc35312dfccd45497462d475
10 changes: 6 additions & 4 deletions test/parallel/test-stream-finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,10 +408,6 @@ testClosed((opts) => new Writable({ write() {}, ...opts }));
// Regression https://github.com/nodejs/node/issues/33130

const response = new PassThrough();
response.write('chunk 1');
response.write('chunk 2');
response.write('chunk 3');
response.end();

class HelloWorld extends Duplex {
constructor(response) {
Expand Down Expand Up @@ -452,6 +448,12 @@ testClosed((opts) => new Writable({ write() {}, ...opts }));
instance.end();

instance.on('finish', common.mustCall(() => {
setImmediate(common.mustCall(() => {
response.write('chunk 1');
response.write('chunk 2');
response.write('chunk 3');
response.end();
}));
(async () => {
assert.strictEqual(instance.writableFinished, true);

Expand Down