Skip to content

stream: don't wait for close on legacy streams #33058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: don't wait for close on legacy streams #33058

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23b724a
stream: don't wait for close on legacy streams
ronag Apr 25, 2020
aef90e3
fixup: test
ronag Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: test
  • Loading branch information
@ronag
ronag committed Apr 25, 2020
commit aef90e36c252e92cffffaf0ac61002cd3feff5f1
12 changes: 12 additions & 0 deletions test/parallel/test-stream-finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,3 +384,15 @@ testClosed((opts) => new Writable({ write() {}, ...opts }));

d.resume();
}

{
// Test for compat for e.g. fd-slicer which implements
// non standard destroy behavior which might not emit
// 'close'.
const r = new Readable();
finished(r, common.mustCall());
r.resume();
r.push('asd');
r.destroyed = true;
r.push(null);
}