Skip to content

stream: pipeline should only destroy un-finished streams. #32968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

stream: pipeline should only destroy un-finished streams. #32968

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fadeba
stream: pipeline should only destroy un-finished streams.
ronag Apr 21, 2020
04b1e3d
fixup: test
ronag Apr 21, 2020
6b92c99
fixup: simplify
ronag Apr 21, 2020
76906a5
fixup: unnecessary once
ronag Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: simplify
  • Loading branch information
@ronag
ronag committed Apr 21, 2020
commit 6b92c9960cd90763efb5a8db7d79e5a78cc62479
5 changes: 2 additions & 3 deletions lib/internal/streams/pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,8 @@ function destroyer(stream, reading, writing, callback) {
});

return once((err) => {
if (!finished) {
destroyImpl.destroyer(stream, err);
}
if (finished) return;
destroyImpl.destroyer(stream, err);
callback(err || new ERR_STREAM_DESTROYED('pipe'));
});
}
Expand Down