Skip to content

src: fix empty-named env var assertion failure #32921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bl-ue wants to merge 5 commits into from
Closed

src: fix empty-named env var assertion failure #32921

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15a7f4c
src: fix empty-named env var assertion failure
bl-ue Apr 18, 2020
afd02b2
src: relax assertion in operator[] of MaybeStackBuffer
bl-ue Apr 19, 2020
1017806
src: do not compare against wide characters
bl-ue Apr 19, 2020
f181bc8
Revert "src: relax assertion in operator[] of MaybeStackBuffer"
bl-ue Apr 20, 2020
446a07a
src: fix env var empty key access in Worker thread
bl-ue Apr 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: fix empty-named env var assertion failure 
Setting an environment variable with an empty name on Windows resulted
in an assertion failure, because it was checked for an '=' sign at the
beginning without verifying the length was greater than 0.

Fixes: #32920
Refs: #27310
  • Loading branch information
@bl-ue
bl-ue committed Apr 19, 2020
commit 15a7f4cbc0bc9eba041cd3a9b7fe62dfeb714847
2 changes: 1 addition & 1 deletion src/node_env_var.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ void RealEnvStore::Set(Isolate* isolate,
node::Utf8Value val(isolate, value);

#ifdef _WIN32
if (key[0] == L'=') return;
if (key.length() > 0 && key[0] == L'=') return;
Comment thread
bl-ue marked this conversation as resolved.
Outdated
#endif
uv_os_setenv(*key, *val);
DateTimeConfigurationChangeNotification(isolate, key);
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-process-env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,11 @@ if (common.isWindows) {
const keys = Object.keys(process.env);
assert.ok(keys.length > 0);
}

// Setting environment variables on Windows with empty names should not cause
// an assertion failure.
// https://github.com/nodejs/node/issues/32920
{
process.env[''] = '';
assert.strictEqual(process.env[''], undefined);
}