stream: simplify Readable push/unshift logic#32899
Closed
himself65 wants to merge 1 commit into
Closed
Conversation
ronag
approved these changes
Apr 17, 2020
Collaborator
Member
lpinca
approved these changes
Apr 17, 2020
BridgeAR
approved these changes
Apr 17, 2020
juanarbol
approved these changes
Apr 21, 2020
Collaborator
Member
|
Benchmark CI looks good, no significant changes. 👍 |
jasnell
approved these changes
Apr 24, 2020
Member
|
@himself65 Looks like this needs a rebase? |
1a07f9c to
878d0e3
Compare
Collaborator
Collaborator
878d0e3 to
789ce34
Compare
Collaborator
Collaborator
Collaborator
789ce34 to
c326431
Compare
Collaborator
ronag
approved these changes
Apr 29, 2020
Member
Author
Collaborator
Member
|
Landed in 0bd24a6 |
ronag
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32899 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2020
PR-URL: #32899 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes