Skip to content

[v14.x] deps: V8: ABI compatibility with master #32885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 19 commits into from
Closed

[v14.x] deps: V8: ABI compatibility with master #32885

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8629a31
deps: V8: cherry-pick 4b1447e4bb0e
addaleax Apr 16, 2020
25f8c9d
deps: V8: cherry-pick 2db93c023379
addaleax Apr 16, 2020
d7d25df
deps: V8: backport 844fe8f7d965
addaleax Apr 16, 2020
5ad3b54
deps: V8: cherry-pick 94723c197199
addaleax Apr 16, 2020
1bbdc48
deps: V8: cherry-pick f0057afc2fb6
addaleax Apr 16, 2020
34b5e8e
deps: V8: cherry-pick fa3e37e511ee
addaleax Apr 16, 2020
2cad1bf
deps: V8: cherry-pick d1253ae95b09
addaleax Apr 16, 2020
e1cd810
deps: V8: cherry-pick e395d1698453
addaleax Apr 16, 2020
059eaf1
deps: V8: cherry-pick 9f0f2cb7f08d
addaleax Apr 16, 2020
59feaea
deps: V8: cherry-pick 55a01ec7519a
addaleax Apr 16, 2020
3596e3f
deps: V8: cherry-pick e8ba5699c648
addaleax Apr 16, 2020
069038e
deps: V8: cherry-pick 700b1b97e9ab
addaleax Apr 16, 2020
95c1245
deps: V8: cherry-pick b5c917ee80cb
addaleax Apr 16, 2020
74717a3
deps: V8: cherry-pick 98b1ef80c722
addaleax Apr 16, 2020
a4a2114
deps: V8: stub backport 9e52d5c5d717
addaleax Apr 16, 2020
e833e05
deps: V8: stub backport 65238018ca4b and 8d08318e1a85
addaleax Apr 16, 2020
d121476
deps: V8: stub backport d5b444bc5a84
addaleax Apr 16, 2020
4237be9
deps: V8: stub backport fast API call changes
addaleax Apr 16, 2020
e4d9295
test: mark addons/zlib-bindings/test flaky on arm
targos Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: stub backport 9e52d5c5d717 
Refs: v8/v8@9e52d5c
  • Loading branch information
@addaleax @targos
addaleax authored and targos committed Apr 18, 2020
commit a4a21141e261d56d06fada7dc875120d10768521
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.26',
'v8_embedder_string': '-node.27',

##### V8 defaults for Node.js #####

Expand Down
5 changes: 4 additions & 1 deletion deps/v8/include/v8-inspector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,10 @@ class V8_EXPORT V8InspectorSession {
virtual void breakProgram(StringView breakReason,
StringView breakDetails) = 0;
virtual void setSkipAllPauses(bool) = 0;
virtual void resume() = 0;

// NOTE: setTerminateOnResume is not implemented on the base version of
// Node.js v14.0.0 / V8 8.1.
virtual void resume(bool setTerminateOnResume = false) = 0;
virtual void stepOver() = 0;
virtual std::vector<std::unique_ptr<protocol::Debugger::API::SearchMatch>>
searchInTextByLines(StringView text, StringView query, bool caseSensitive,
Expand Down
4 changes: 3 additions & 1 deletion deps/v8/src/inspector/v8-inspector-session-impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,9 @@ void V8InspectorSessionImpl::setSkipAllPauses(bool skip) {
m_debuggerAgent->setSkipAllPauses(skip);
}

void V8InspectorSessionImpl::resume() { m_debuggerAgent->resume(); }
void V8InspectorSessionImpl::resume(bool terminateOnResume) {
m_debuggerAgent->resume();
}

void V8InspectorSessionImpl::stepOver() { m_debuggerAgent->stepOver(); }

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/inspector/v8-inspector-session-impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class V8InspectorSessionImpl : public V8InspectorSession,
void cancelPauseOnNextStatement() override;
void breakProgram(StringView breakReason, StringView breakDetails) override;
void setSkipAllPauses(bool) override;
void resume() override;
void resume(bool terminateOnResume = false) override;
void stepOver() override;
std::vector<std::unique_ptr<protocol::Debugger::API::SearchMatch>>
searchInTextByLines(StringView text, StringView query, bool caseSensitive,
Expand Down