Skip to content

stream: remove unused & undocumented cb #32865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 1 commit into from
Closed

stream: remove unused & undocumented cb #32865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
stream: remove unused & undocumented cb 
destroy(err, cb) was an undocumented API which
was previously used internally by core modules.
However, this is no longer the case and it should
be possible to safely remove this.

Refs: #32808
  • Loading branch information
@ronag
ronag committed Apr 15, 2020
commit 2b4815b9f7b0801ea8ec240b8eded63dde4f8ccb
14 changes: 1 addition & 13 deletions lib/internal/streams/destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,10 @@
'use strict';

// Undocumented cb() API, needed for core, not for public API.
// The cb() will be invoked synchronously if _destroy is synchronous.
// If cb is passed no 'error' event will be emitted.
function destroy(err, cb) {
function destroy(err) {
const r = this._readableState;
const w = this._writableState;

if ((w && w.destroyed) || (r && r.destroyed)) {
if (typeof cb === 'function') {
// TODO(ronag): Invoke with `'close'`/`'error'`.
cb();
}

return this;
}

Expand Down Expand Up @@ -52,10 +44,6 @@ function destroy(err, cb) {
r.closed = true;
}

if (typeof cb === 'function') {
cb(err);
}

if (err) {
process.nextTick(emitErrorCloseNT, this, err);
} else {
Expand Down